[Do not merge] dApp-friendly contract deployment #118
Conversation
Reduce the unstake period to 120s(2min) instead of 24h. Thanks to this we can test the unstake flow w/o waiting 24h.
Run this script only for the goerli test network.
To protect the `*.sol` files. This is a protection to enforce the never-merge rule for dApp development fine-tuned parameters.
|
Could you change this PR to draft and add a visible info in the description that those changes are not supposed to get merged to |
pdyraga
changed the title
CODEOWNERS
Outdated
| @@ -0,0 +1 @@ | |||
| *.sol @pdyraga @nkuba @lukasz-zimnoch | |||
There was a problem hiding this comment.
Let's extract CODEOWNERS change to a separate PR and merge it to main.
The CODEOWNERS should cover all existing contracts from contracts/ directory
Let's add there all developers who worked on the Solidity code of the Threshold smart contracts: @vzotova @cygnusv @pdyraga
This will not only protect dApp-dev-only changes from being merged but will also protect from any accidental changes to an already audited code.
|
|
||
| const { deployer } = await getNamedAccounts() | ||
|
|
||
| const minStakeAmount = "39999999999999999999999" |
There was a problem hiding this comment.
Why do we want to set the minimum stake to 39999999999999999999999? With dApp team owning T token contract from dapp-development-goerli deployment, all devs should be able to mint any amount of T they want.
There was a problem hiding this comment.
39999999999999999999999 is the current min stake on mainnet that's why I picked this number but we could change to any number. We want to set the min stake to test the min stake validation in T dapp.
Fix scritp that sets the min stake amount in the T token staking contract. I've missed passing the `amount` argument to the `setMinimumStakeAmount` function.
We are publishing packages with code from `dapp-development` branch under versions that use `-dapp-dev-goerli.X` suffix. Our `package.json` on this branch should reflect that. If we do not set it up, the CI job used to pubblish the package will not be able to correctly bump up the version of the package.
|
Solidity API documentation preview available in the artifacts of the https://github.com/threshold-network/solidity-contracts/actions/runs/6783566823 check. |
We're switching deployment to the Sepolia testnet due to planned deprecation of the Goerli testnet. In a previous commit we've updated the `dapp-development` branch with the recent changes from `main` (among them were the changes adding Sepolia to the list of supported networks). Now we're updating the `dapp-development` branch to create `dapp-dev-sepolia` packages.
|
Solidity API documentation preview available in the artifacts of the https://github.com/threshold-network/solidity-contracts/actions/runs/6783635251 check. |
Ref: threshold-network/token-dashboard#136
We need a dApp-friendly version of deployment allowing dashboard developers to build UI components without having to run geth/ganache/hardhat locally and deploying contracts locally.
This PR aims at presenting changes to smart contracts deployed to Sepolia that are used by the dApp development team for day-to-day work. Please do not merge this PR to
mainbranch. Smart contract with the changes presented here are pushed to NPM registry with a tagdapp-development-sepolia.Main changes:
39999999999999999999999(only for the Sepolia network).